This repository has been archived by the owner on May 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I've been using
fancy-test
(by way of@oclif/test
) and using Jest as my test runner (since that's what I was already using to run all the tests in my monorepo), and it pretty much just works. It's been great.The only thing I've run into is that I have to include
@types/jest
in my monorepo, and since I do, when I try to build my package with TypeScript, I get some errors that look like this:I've been able to get around this by setting
"skipLibCheck": true
in mytsconfig.json
, but I'd like to not skip checks if possible.This PR brings in mocha's
Done
type (basically the same kind of thing that was already done in d011192). It also moves@types/mocha
to devDependencies instead of dependencies, since after this change as far as I can tell the mocha types aren't used in the src code itself. By moving@types/mocha
to devDependencies, if you addfancy-test
it to a project, it won't add@types/mocha
, too, and you can avoid clashes with@types/jest
.